Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sunrise and sunset to Darksky weather sensor #19492

Merged
merged 2 commits into from Dec 22, 2018
Merged

Add sunrise and sunset to Darksky weather sensor #19492

merged 2 commits into from Dec 22, 2018

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Dec 20, 2018

Description:

Add sunrise and sunset to Darksky weather sensor.

Related issue (if applicable): fixes 85438

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7917

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: darksky
    api_key: !secret darksky_api
    forecast:
      - 0
    monitored_conditions:
      - sunrise_time
      - sunset_time

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

@ghost ghost assigned fabaff Dec 20, 2018
@ghost ghost added the in progress label Dec 20, 2018
@cgarwood cgarwood merged commit 6880be5 into dev Dec 22, 2018
@delete-merged-branch delete-merged-branch bot deleted the darksky-sun branch December 22, 2018 13:52
@ghost ghost removed the in progress label Dec 22, 2018
dshokouhi pushed a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018
* Add sunrise and sunset to Darksky weather sensor

* Fix lint issue
@balloob balloob mentioned this pull request Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants