Fix london_underground issue #19642
Merged
Fix london_underground issue #19642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
platform: sensor.london_underground
small-pr
houndci-bot
reviewed
Dec 29, 2018
| reason = ' *** '.join( | ||
| [status['reason'] for status in line['lineStatuses']]) | ||
| reason = ' *** '.join([status['disruption']['additionalInfo'] | ||
| for status in line['lineStatuses']]) |
There was a problem hiding this comment.
continuation line over-indented for visual indent
| statuses = [status['statusSeverityDescription'] | ||
| for status in line['lineStatuses']] | ||
| state = ' + '.join(sorted(set(statuses))) | ||
|
|
||
| if state == 'Good Service': | ||
| if state == 'Good Service': # if good status, this is the only status returned |
There was a problem hiding this comment.
line too long (88 > 79 characters)
houndci-bot
reviewed
Dec 29, 2018
| reason = ' *** '.join( | ||
| [status['reason'] for status in line['lineStatuses']]) | ||
| reason = ' *** '.join([status['disruption']['additionalInfo'] | ||
| for status in line['lineStatuses']]) |
There was a problem hiding this comment.
continuation line under-indented for visual indent
houndci-bot
reviewed
Dec 29, 2018
| @@ -127,7 +128,10 @@ def parse_api_response(response): | |||
| reason = 'Nothing to report' | |||
| else: | |||
| reason = ' *** '.join( | |||
| [status['reason'] for status in line['lineStatuses']]) | |||
| [status['disruption']['additionalInfo'] for status | |||
| in line['lineStatuses']] | |||
There was a problem hiding this comment.
continuation line under-indented for visual indent
There was a problem hiding this comment.
Can anyone help here? Spent 15 mins trying this
| @@ -127,7 +128,10 @@ def parse_api_response(response): | |||
| reason = 'Nothing to report' | |||
| else: | |||
| reason = ' *** '.join( | |||
| [status['reason'] for status in line['lineStatuses']]) | |||
| [status['disruption']['additionalInfo'] for status | |||
MartinHjelmare
requested changes
Dec 30, 2018
| statuses = [status['statusSeverityDescription'] | ||
| for status in line['lineStatuses']] | ||
| state = ' + '.join(sorted(set(statuses))) | ||
|
|
||
| if state == 'Good Service': | ||
| reason = 'Nothing to report' | ||
| else: | ||
| reason = ' *** '.join( | ||
| [status['reason'] for status in line['lineStatuses']]) | ||
| reason = " *** ".join( |
There was a problem hiding this comment.
The service interface, I/O and data parsing, should be moved to a standalone library published on pypi.
|
@MartinHjelmare changes made |
|
Thanks! |
Merged
kellerza
pushed a commit
to kellerza/home-assistant
that referenced
this pull request
Jan 18, 2019
* Update london_underground.py * Update test * Update london_underground.py * Update london_underground.py * Update london_underground.py * Fix lint * Use london-tube-status==0.2
alandtse
pushed a commit
to alandtse/home-assistant
that referenced
this pull request
Feb 12, 2019
* Update london_underground.py * Update test * Update london_underground.py * Update london_underground.py * Update london_underground.py * Fix lint * Use london-tube-status==0.2
ghost
added
integration: london_underground
and removed
platform: sensor.london_underground
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Now using https://pypi.org/project/london-tube-status/
Related issue (if applicable): fixes #19639