WIP: Add firmware and config version attributes to harmony component #19647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use aioharmony to interact with Harmony hub. Due to this following improvements: -) Setting of available state for entity -) Automatic config update if configuration changes (including updating file containing config) -) Allow using of device name instead of number -) When sending command with repeat, nothing else will be able to put a IR command in between
Updated requirements
ghost
added
the
4 tasks
Small version bump increase for aioharmony
Add firmware and config version attributes
ehendrix23
force-pushed
the
Add-attributes
branch
from
0a55797
to
c755231
Compare
MartinHjelmare
requested changes
Dec 30, 2018
| return {'current_activity': self._current_activity} | ||
| return { | ||
| ATTR_CURRENT_ACTIVITY: self._current_activity, | ||
| ATTR_FIRMWARE_VERSION: self._client.fw_version, |
There was a problem hiding this comment.
No. Static info like firmware version and config version should not be part of state attributes. State attributes are meant for dynamic info related to the state of the entity.
Device info can hold this kind of static info. But it requires config entry.
https://developers.home-assistant.io/docs/en/device_registry_index.html
There was a problem hiding this comment.
Ah, Ok. I thought in having it in there due to our latest issues around firmware :-)
Config entry is something I wanna move this platform to, but not there yet. Will cancel out this PR. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add attributes the following 2 attributes to the harmony component:
firmware_version: Version of the Harmony HUB version
config_version: Configuration version of the Harmony HUB
This PR depends on PR #19595 to be merged first.
Checklist:
tox. Your PR cannot be merged unless tests pass