Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade huawei-lte-api to 1.1.3 #19987

Merged
merged 1 commit into from Jan 12, 2019
Merged

Upgrade huawei-lte-api to 1.1.3 #19987

merged 1 commit into from Jan 12, 2019

Conversation

scop
Copy link
Member

@scop scop commented Jan 11, 2019

Description:

https://github.com/Salamek/huawei-lte-api/commits/master

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob
Copy link
Member

balloob commented Jan 11, 2019

Ask people to install release drafter to get an easy change log going https://github.com/apps/release-drafter

@balloob balloob merged commit 83c5dc6 into home-assistant:dev Jan 12, 2019
@scop scop deleted the upgrade-huawei-lte-api branch January 12, 2019 09:38
@balloob balloob mentioned this pull request Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants