New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out gpslogger into a separate component and platform #20044
Split out gpslogger into a separate component and platform #20044
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update coveragerc too. What's the coverage? Can we remove the device tracker platform or should we add the component?
The device tracker platform is currently in I can add a couple more component tests and I think we can remove the device tracker platform from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Can be merged when build passes. |
Build seems to have failed due to unrelated things, will close/reopen to trigger another. |
If it's a known flaky test we can just ignore it. But let's see what this build has to offer. |
Description:
Splits the gpslogger device tracker to be a component in addition to the device_tracker platform. This is required to migrate it over to use the webhook component.
Breaking Change: The gpslogger device_tracker platform no longer takes any configuration. The configuration needs to be applied to the component gpslogger instead. The platform will be automatically loaded with the component and should not be specified in configuration.yaml.
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8152
Example entry for
configuration.yaml
(if applicable):gpslogger:
Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: