Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tellduslive responsiveness #20603

Merged
merged 8 commits into from
Feb 5, 2019

Conversation

fredrike
Copy link
Contributor

@fredrike fredrike commented Jan 30, 2019

Description:

Various fixes to make tellduslive more responsive.

Related issue (if applicable):
fixes #20268, fixes #20222, related #20169

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@MartinHjelmare
Copy link
Member

We also need the library update to fix the issues.

@fredrike
Copy link
Contributor Author

We also need the library update to fix the issues.

That is why I tagged it with WIP. I'm waiting for molobrakos/tellduslive#19 to be merged and a version up.

@fredrike fredrike changed the title wip: Tellduslive responsiveness Fix: tellduslive responsiveness Feb 4, 2019
@MartinHjelmare MartinHjelmare changed the title Fix: tellduslive responsiveness Fix tellduslive responsiveness Feb 4, 2019
@MartinHjelmare MartinHjelmare added this to the 0.87.0 milestone Feb 5, 2019
@MartinHjelmare
Copy link
Member

Thanks!

Can be merged when build passes.

@balloob balloob merged commit c76a61a into home-assistant:dev Feb 5, 2019
@ghost ghost removed the in progress label Feb 5, 2019
balloob pushed a commit that referenced this pull request Feb 6, 2019
* use async_call_later for update

* no need to timeout

* fixes

* move init tasks to hass.loop

* version bump of tellduslive

* fixes for @MartinHjelmare

* fixes task cancel

* don't return from new client
@balloob balloob mentioned this pull request Feb 6, 2019
bachya pushed a commit to bachya/home-assistant that referenced this pull request Feb 7, 2019
* use async_call_later for update

* no need to timeout

* fixes

* move init tasks to hass.loop

* version bump of tellduslive

* fixes for @MartinHjelmare

* fixes task cancel

* don't return from new client
@fredrike fredrike deleted the tellduslive-responsiveness branch March 4, 2019 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tellduslive makes home assistant unresponsive Telldus Live Stopped working
4 participants