-
-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tellduslive responsiveness #20603
Merged
balloob
merged 8 commits into
home-assistant:dev
from
fredrike:tellduslive-responsiveness
Feb 5, 2019
Merged
Fix tellduslive responsiveness #20603
balloob
merged 8 commits into
home-assistant:dev
from
fredrike:tellduslive-responsiveness
Feb 5, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
in progress
label
Jan 30, 2019
We also need the library update to fix the issues. |
That is why I tagged it with WIP. I'm waiting for molobrakos/tellduslive#19 to be merged and a version up. |
fredrike
commented
Jan 31, 2019
fredrike
force-pushed
the
tellduslive-responsiveness
branch
from
February 1, 2019 09:41
3a7d608
to
e333fb1
Compare
fredrike
changed the title
wip: Tellduslive responsiveness
Fix: tellduslive responsiveness
Feb 4, 2019
MartinHjelmare
changed the title
Fix: tellduslive responsiveness
Fix tellduslive responsiveness
Feb 4, 2019
MartinHjelmare
approved these changes
Feb 5, 2019
Thanks! Can be merged when build passes. |
ghost
removed
the
in progress
label
Feb 5, 2019
balloob
pushed a commit
that referenced
this pull request
Feb 6, 2019
* use async_call_later for update * no need to timeout * fixes * move init tasks to hass.loop * version bump of tellduslive * fixes for @MartinHjelmare * fixes task cancel * don't return from new client
Merged
bachya
pushed a commit
to bachya/home-assistant
that referenced
this pull request
Feb 7, 2019
* use async_call_later for update * no need to timeout * fixes * move init tasks to hass.loop * version bump of tellduslive * fixes for @MartinHjelmare * fixes task cancel * don't return from new client
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Various fixes to make tellduslive more responsive.
Related issue (if applicable):
fixes #20268, fixes #20222, related #20169
Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: