Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique Ids for August entities to allow renames #20887

Merged
merged 11 commits into from Feb 11, 2019
Merged

Unique Ids for August entities to allow renames #20887

merged 11 commits into from Feb 11, 2019

Conversation

wonderslug
Copy link
Contributor

Description:

This sets up unique ids on the august devices to allow for the devices to be used in the registry and support renames of them. This should be backwards compatible and does not effect the entity_id and name.

Example entry for configuration.yaml (if applicable):

august:
  login_method: email
  username: !secret august_user
  password: !secret august_password

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@homeassistant homeassistant added integration: august small-pr PRs with less than 30 lines. labels Feb 9, 2019
@ghost ghost added the in progress label Feb 9, 2019
homeassistant/components/august/lock.py Outdated Show resolved Hide resolved
homeassistant/components/august/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/august/binary_sensor.py Outdated Show resolved Hide resolved
Copy link
Contributor

@amelchio amelchio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Just checking: what does the device_id look like?

@wonderslug
Copy link
Contributor Author

The august devices have a cloud id that is not directly related to the serial number. These ids come across as part of the protocol and would be fairly unique per cloud account, and probably across the august system as well.

For the doorbell the doorbellID is used:

{  
   "doorbellID":"62d76ac1XXXX",
   "serialNumber":"D2GTD0XXXX",
   "appID":"august-iphone-v5",
   "installUserID":"8f9e6c84-cc11-4971-b5df-XXXXXXXXXXXX",
   "name":"Front Door",
   "installDate":"2017-12-17T23:44:28.697Z",
   ....

For the lock the lockID is used :

{  
   "LockName":"Front Door",
   "Type":3,
   "Created":"2017-10-21T22:24:56.754Z",
   "Updated":"2017-10-21T22:24:56.754Z",
   "LockID":"D4F29513A742499DAAE2888F3F3XXXXX",
   "HouseID":"e9d48d9a-3210-4cd3-a6b4-XXXXXXXXXXXX",
   "HouseName":"Home",
   "Calibrated":false,
   "skuNumber":"AUG-SL03-C02-S03",
    ....

@cgarwood cgarwood merged commit c3c9223 into home-assistant:dev Feb 11, 2019
@ghost ghost removed the in progress label Feb 11, 2019
@balloob balloob mentioned this pull request Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants