Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ZHA device availability on new join #21066

Merged
merged 2 commits into from Feb 15, 2019
Merged

Set ZHA device availability on new join #21066

merged 2 commits into from Feb 15, 2019

Conversation

dmulcahey
Copy link
Contributor

Fix device availability on new joins

@ghost ghost assigned dmulcahey Feb 14, 2019
@ghost ghost added the in progress label Feb 14, 2019
@dmulcahey dmulcahey added this to the 0.88.0 milestone Feb 14, 2019
Adminiuga
Adminiuga previously approved these changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@Adminiuga Adminiuga left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the tests, otherwise looks good!

@Adminiuga Adminiuga dismissed their stale review February 14, 2019 19:15

need to fix the tests

@dmulcahey
Copy link
Contributor Author

dmulcahey commented Feb 15, 2019 •
edited

They just need to rerun... happens a lot NVM... I do have stuff to fix

MartinHjelmare
MartinHjelmare approved these changes Feb 15, 2019
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged when build passes.

@dmulcahey dmulcahey merged commit 3a6a246 into home-assistant:dev Feb 15, 2019
@ghost ghost removed the in progress label Feb 15, 2019
balloob pushed a commit that referenced this pull request Feb 15, 2019
@dmulcahey @balloob
Set ZHA device availability on new join (#21066)
2b6b922 
* set availability on device join

* fix new join test
@dmulcahey dmulcahey deleted the dm/zha-available-on-new-join branch February 15, 2019 22:35
@balloob balloob mentioned this pull request Feb 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@Adminiuga Adminiuga Adminiuga left review comments

Assignees

@dmulcahey dmulcahey

Labels
cherry-picked cla-signed integration: zha small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.88.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dmulcahey @MartinHjelmare @Adminiuga @balloob @homeassistant