Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Person component: Handle ValueError #21126

Merged
merged 1 commit into from
Feb 17, 2019
Merged

Person component: Handle ValueError #21126

merged 1 commit into from
Feb 17, 2019

Conversation

balloob
Copy link
Member

@balloob balloob commented Feb 16, 2019

Description:

Person component: Handle ValueError and render appropriate error message in frontend.

@balloob balloob added this to the 0.88.0 milestone Feb 16, 2019
@ghost ghost assigned balloob Feb 16, 2019
@ghost ghost added the in progress label Feb 16, 2019
device_trackers=msg['device_trackers']
)
connection.send_result(msg['id'], person)
except ValueError as err:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When does it happen?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate user id

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Delete person also raises ValueError.

@balloob balloob merged commit 9c92880 into dev Feb 17, 2019
@ghost ghost removed the in progress label Feb 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the person-fixes branch February 17, 2019 03:39
balloob added a commit that referenced this pull request Feb 17, 2019
@balloob balloob mentioned this pull request Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants