Make time trigger data trigger.now local #21544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
balloob
reviewed
Feb 28, 2019
|
If we're able to track down the cause, we should tag this PR for the 89 milestone. |
houndci-bot
reviewed
Mar 1, 2019
houndci-bot
reviewed
Mar 1, 2019
Thanks for reviewing! Now fixed by making sure we call the event handler with local time instead of converting to local time in the event handler: https://github.com/home-assistant/home-assistant/blob/e8f122c5518275dc93c1aaf4879113dd258c17c7/homeassistant/helpers/event.py#L373-L375 |
balloob
approved these changes
Mar 2, 2019
| @@ -370,7 +370,9 @@ def pattern_time_change_listener(event): | |||
| last_now = now | |||
|
|
|||
| if next_time <= now: | |||
| hass.async_run_job(action, event.data[ATTR_NOW]) | |||
| if local: | |||
| now = dt_util.as_local(now) | |||
There was a problem hiding this comment.
Does it matter that we now pass local time to calculate_next?
Merged
balloob
pushed a commit
that referenced
this pull request
Mar 5, 2019
* Make time trigger data trigger.now local * Make time pattern trigger data trigger.now local * Lint * Rework according to review comment * Lint
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix regression introduced by #17199 where time trigger is in local timezone but the time trigger data is in UTC. This fix changes back to previous behavior where both time trigger and the time trigger data is in local timezone
Related issue (if applicable): fixes #20110
Checklist:
tox. Your PR cannot be merged unless tests pass