Synology sensor quick return if attr is null #21709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some case where attr is null. Returning null doesn't change anything (in my case this is mapped to a volume that doesn't exist, not sure what others are seeing). If you have confirmed you hass instance for C instead of F you do not see this error.
homeassistant
added
cla-signed
platform: sensor.synologydsm
small-pr
ghost
added
the
houndci-bot
reviewed
Mar 6, 2019
| @@ -229,6 +229,9 @@ def state(self): | |||
| if self.var_id in temp_sensors: | |||
| attr = getattr( | |||
| self._api.storage, self.var_id)(self.monitor_device) | |||
|
|
|||
| if attr == None: | |||
There was a problem hiding this comment.
comparison to None should be 'if cond is None:'
| @@ -229,6 +229,9 @@ def state(self): | |||
| if self.var_id in temp_sensors: | |||
| attr = getattr( | |||
| self._api.storage, self.var_id)(self.monitor_device) | |||
|
|
|||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
There are some case where attr is null. Returning null doesn't change anything (in my case this is mapped to a volume that doesn't exist, not sure what others are seeing).
If you have confirmed you hass instance for C instead of F you do not see this error since in the C case you indirectly do the quick return and don't try to convert a None value.
Checklist:
tox. Your PR cannot be merged unless tests pass