New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix colorlog import error #21754
Fix colorlog import error #21754
Conversation
I'm confused. The script |
I will mark this for 0.89.1, we can do a proper fix when we're not doing hotfixes. |
* Fix colorlog import error * Lint
Ah, maybe I missed read the #20517, I through its intention is prevent install colorlog. Let me check it again. |
@balloob is correct, you should have focused on |
I wonder if the extra deps dir is properly mounted when we're running scripts? https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/bootstrap.py#L368-L377 |
* Fix script load depedency * Revert #21754
* Fix script load depedency * Revert #21754
Description:
colorlog is not part of core dependency. We should ignore the import error and fallback to black and white.
Fix the side effect of #20517, cc @kellerza
See user complain here:
https://community.home-assistant.io/t/0-89-nissan-leaf-playstation-4-point-alarm-control-owlet-baby-monitor/103767/12
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests pass