Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Waze Travel Time & Update Requirements #22428

Merged
merged 4 commits into from Jun 6, 2019
Merged

Refactor Waze Travel Time & Update Requirements #22428

merged 4 commits into from Jun 6, 2019

Conversation

Petro31
Copy link
Contributor

@Petro31 Petro31 commented Mar 26, 2019

Refactored Waze Travel Time to contain a data object.

Changed error retrieving data to a warning.
Added distance conversion depending on region.
Removed dependency on TRACKABLE_DOMAINS list.
Update to use WazeRouteCalculator 0.10

3rd time's a charm. Deleted fork, caused last PR to screw up. So here we are.

Breaking Change:

Description:

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8825

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@Petro31
Copy link
Contributor Author

Petro31 commented Mar 26, 2019

Deleted fork because of unrelated issues. Unable to update #22226 because of the missing fork. Created this PR instead.

@Petro31 Petro31 closed this Apr 3, 2019
@Petro31 Petro31 reopened this Apr 3, 2019
@ghost ghost added in progress and removed in progress labels Apr 3, 2019
Refactored Waze Travel Time to contain a data object.

Changed error retrieving data to a warning.
Added distance conversion depending on region.
Removed dependency on TRACKABLE_DOMAINS list.
Update to use WazeRouteCalculator 0.10

3rd time's a charm.  Deleted fork, caused last PR to screw up.  So here we are.
@ikifar2012 ikifar2012 mentioned this pull request Apr 16, 2019
@MartVisser
Copy link

Any idea when this is going to be merged? This is a breaking fix right, I can't get travel times now with the waze_travel_time component.

@Petro31
Copy link
Contributor Author

Petro31 commented Apr 25, 2019

No clue. You can add it as a custom component and it will overwrite what you have.

@dennusb
Copy link

dennusb commented Apr 30, 2019

No clue. You can add it as a custom component and it will overwrite what you have.

How should i add it? custom_components/waze/sensor.py?

@Petro31
Copy link
Contributor Author

Petro31 commented Apr 30, 2019

custom_components/waze_travel_time/sensor.py

@radinsky
Copy link

any estimate to merge?

@edif30
Copy link
Contributor

edif30 commented May 22, 2019

If all checks passed, why are there conflicts?

@Petro31
Copy link
Contributor Author

Petro31 commented May 22, 2019

Because this sat here for 3 months. I'm going to create a new PR sometime in the near future. At that point, I'm going to add a few new functions and I'm going to ping the devs to take a look at it. As for this PR, it looks like it has been ignored.

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Thanks! 🐬

@balloob balloob merged commit 2c341f2 into home-assistant:dev Jun 6, 2019
balloob pushed a commit that referenced this pull request Jun 25, 2019
* Update manifest.json

Update waze calculator to 0.10, this was supposed to have been done in #22428 but was missed. See discussion [here](https://community.home-assistant.io/t/waze-travel-time-update/50955/201)

* Update requirements_all.txt
balloob pushed a commit that referenced this pull request Jun 26, 2019
* Update manifest.json

Update waze calculator to 0.10, this was supposed to have been done in #22428 but was missed. See discussion [here](https://community.home-assistant.io/t/waze-travel-time-update/50955/201)

* Update requirements_all.txt
@balloob balloob mentioned this pull request Jun 26, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
* Refactor Waze Travel Time & Update Requirements

Refactored Waze Travel Time to contain a data object.

Changed error retrieving data to a warning.
Added distance conversion depending on region.
Removed dependency on TRACKABLE_DOMAINS list.
Update to use WazeRouteCalculator 0.10

3rd time's a charm.  Deleted fork, caused last PR to screw up.  So here we are.

* Update requirements_all.txt

* Revert package upgrade.

* Revert package upgrade.
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
* Update manifest.json

Update waze calculator to 0.10, this was supposed to have been done in home-assistant#22428 but was missed. See discussion [here](https://community.home-assistant.io/t/waze-travel-time-update/50955/201)

* Update requirements_all.txt
@Petro31 Petro31 deleted the patch-1 branch February 7, 2020 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants