New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Waze Travel Time & Update Requirements #22428
Conversation
Deleted fork because of unrelated issues. Unable to update #22226 because of the missing fork. Created this PR instead. |
Refactored Waze Travel Time to contain a data object. Changed error retrieving data to a warning. Added distance conversion depending on region. Removed dependency on TRACKABLE_DOMAINS list. Update to use WazeRouteCalculator 0.10 3rd time's a charm. Deleted fork, caused last PR to screw up. So here we are.
Any idea when this is going to be merged? This is a breaking fix right, I can't get travel times now with the waze_travel_time component. |
No clue. You can add it as a custom component and it will overwrite what you have. |
How should i add it? custom_components/waze/sensor.py? |
custom_components/waze_travel_time/sensor.py |
any estimate to merge? |
If all checks passed, why are there conflicts? |
Because this sat here for 3 months. I'm going to create a new PR sometime in the near future. At that point, I'm going to add a few new functions and I'm going to ping the devs to take a look at it. As for this PR, it looks like it has been ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Thanks! 🐬
* Update manifest.json Update waze calculator to 0.10, this was supposed to have been done in #22428 but was missed. See discussion [here](https://community.home-assistant.io/t/waze-travel-time-update/50955/201) * Update requirements_all.txt
* Update manifest.json Update waze calculator to 0.10, this was supposed to have been done in #22428 but was missed. See discussion [here](https://community.home-assistant.io/t/waze-travel-time-update/50955/201) * Update requirements_all.txt
* Refactor Waze Travel Time & Update Requirements Refactored Waze Travel Time to contain a data object. Changed error retrieving data to a warning. Added distance conversion depending on region. Removed dependency on TRACKABLE_DOMAINS list. Update to use WazeRouteCalculator 0.10 3rd time's a charm. Deleted fork, caused last PR to screw up. So here we are. * Update requirements_all.txt * Revert package upgrade. * Revert package upgrade.
* Update manifest.json Update waze calculator to 0.10, this was supposed to have been done in home-assistant#22428 but was missed. See discussion [here](https://community.home-assistant.io/t/waze-travel-time-update/50955/201) * Update requirements_all.txt
Refactored Waze Travel Time to contain a data object.
Changed error retrieving data to a warning.
Added distance conversion depending on region.
Removed dependency on TRACKABLE_DOMAINS list.
Update to use WazeRouteCalculator 0.10
3rd time's a charm. Deleted fork, caused last PR to screw up. So here we are.
Breaking Change:
Description:
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8825
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: