Solax Inverter Sensor Component #22579

squishykid · 2019-03-31T04:08:07Z

Description:

This component adds support for Solax solar inverters. These inverters may be connected to a home Wi-Fi network and expose a REST endpoint. This component polls that endpoint and exposes the information as sensor data to home-assistant.

Future pull requests will add support for exposing specific attributes, but I want to keep the first contribution small 😊.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9082

Example entry for `configuration.yaml` (if applicable):

- platform: solax
  ip_address: '192.168.0.123'

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
New dependencies are only imported inside functions that use them ([example][ex-import]).
New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
New files were added to .coveragerc.

homeassistant · 2019-03-31T04:08:09Z

Hi @squishykid,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

homeassistant/components/solax/sensor.py

awarecan · 2019-04-04T16:38:24Z

It is harsh time for new integration as we are doing refactoring, we are now requesting all components has to have a manifest file.

Please rebase you branch against current dev branch, and create a manifest.json file under your component's folder.

You may need to do more rebase in the next few days as we are still in the progress of refactoring.

squishykid · 2019-04-04T21:51:57Z

Ok, thanks for the info. I might wait I a few days before continuing work on this then.

…into solax-inverter

…into solax-inverter # Conflicts: # .coveragerc

This reverts commit 82a6c0c.

squishykid · 2019-04-11T07:20:44Z

@rohankapoorcom @awarecan Review comments and manifest have been addressed, should be ready to merge now 😊

homeassistant/components/solax/sensor.py

homeassistant/components/solax/manifest.json

rohankapoorcom · 2019-04-27T05:23:06Z

@squishykid A couple more (minor) comments, otherwise this is looking good!

…into solax-inverter

homeassistant/components/solax/sensor.py

codecov · 2019-05-06T12:37:01Z

Codecov Report

Merging #22579 into dev will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev   #22579      +/-   ##
==========================================
- Coverage   93.89%   93.83%   -0.06%     
==========================================
  Files         464      448      -16     
  Lines       37877    36583    -1294     
==========================================
- Hits        35566    34329    -1237     
+ Misses       2311     2254      -57

Impacted Files	Coverage Δ
homeassistant/components/mqtt/fan.py	`74.33% <0%> (-23.64%)`	⬇️
homeassistant/components/mqtt/light/schema_json.py	`73.06% <0%> (-20.65%)`	⬇️
homeassistant/bootstrap.py	`58.08% <0%> (-17.21%)`	⬇️
homeassistant/components/mqtt/lock.py	`91.83% <0%> (-8.17%)`	⬇️
homeassistant/components/axis/device.py	`93.02% <0%> (-6.98%)`	⬇️
homeassistant/components/hassio/ingress.py	`71.3% <0%> (-6.75%)`	⬇️
homeassistant/helpers/template.py	`95.54% <0%> (-4.46%)`	⬇️
homeassistant/components/deconz/config_flow.py	`97.77% <0%> (-2.23%)`	⬇️
homeassistant/components/zha/core/registries.py	`85% <0%> (-1.96%)`	⬇️
homeassistant/components/hue/bridge.py	`73.07% <0%> (-1%)`	⬇️
... and 202 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3925b7...ca43123. Read the comment docs.

codecov · 2019-05-06T12:37:03Z

Codecov Report

Merging #22579 into dev will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev   #22579      +/-   ##
==========================================
- Coverage   93.89%   93.83%   -0.06%     
==========================================
  Files         464      448      -16     
  Lines       37877    36583    -1294     
==========================================
- Hits        35566    34329    -1237     
+ Misses       2311     2254      -57

Impacted Files	Coverage Δ
homeassistant/components/mqtt/fan.py	`74.33% <0%> (-23.64%)`	⬇️
homeassistant/components/mqtt/light/schema_json.py	`73.06% <0%> (-20.65%)`	⬇️
homeassistant/bootstrap.py	`58.08% <0%> (-17.21%)`	⬇️
homeassistant/components/mqtt/lock.py	`91.83% <0%> (-8.17%)`	⬇️
homeassistant/components/axis/device.py	`93.02% <0%> (-6.98%)`	⬇️
homeassistant/components/hassio/ingress.py	`71.3% <0%> (-6.75%)`	⬇️
homeassistant/helpers/template.py	`95.54% <0%> (-4.46%)`	⬇️
homeassistant/components/deconz/config_flow.py	`97.77% <0%> (-2.23%)`	⬇️
homeassistant/components/zha/core/registries.py	`85% <0%> (-1.96%)`	⬇️
homeassistant/components/hue/bridge.py	`73.07% <0%> (-1%)`	⬇️
... and 202 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3925b7...ca43123. Read the comment docs.

squishykid · 2019-05-12T13:08:13Z

@rohankapoorcom should be ready to go again. Attempt 2!

…into solax-inverter

rohankapoorcom · 2019-05-26T02:55:22Z

Sorry for the delay, we're good to go here!

MJP-76 · 2019-06-06T21:34:59Z

Nice work here. Let me know if you need any testing. I have two Solax inverters, 1 x Hybrid with Batteries and 1 x X1 inverter

Happy to do beta testing etc

kprzeb · 2019-06-14T20:14:20Z

Hello Is this sensor working witch solax X3 inverter ?

squishykid · 2019-06-15T00:05:28Z

@kprzeb Give it a go and let us know if it works with your inverter.

I have tested it with a Solax SK-TL5000E

MJP-76 · 2019-06-18T08:47:42Z

I use a Solax X1 SK-SU5000E and Solax X1-2.5-S-D (X1-Air) and both work

kprzeb · 2019-06-20T20:12:31Z

Sorry for delay
I have SolaX Power X3-8.0 I connect it to my WiFi network and add HA sensor:

- platform: solax
  ip_address: '192.168.7.15'

HA dont read any values. IP is correct.
On host 192.168.7.15 I cant see any web interface, pings replay, port 80 is open
Can I help develop this problem ?
What can I check?
Thenks

MartinHjelmare · 2019-06-20T22:04:36Z

Please open an issue if you suspect a bug. If you need help please use our help channels:
https://home-assistant.io/help/#communication-channels

Merged PRs should not be used for support or bug reports. Thanks!

Solax inverter direct API

eb27878

homeassistant added cla-needed new-integration new-platform integration: solax labels Mar 31, 2019

ghost added the in progress label Mar 31, 2019

homeassistant added cla-signed and removed cla-needed labels Mar 31, 2019

CountParadox mentioned this pull request Mar 31, 2019

Create sensor.solax home-assistant/home-assistant.io#9082

Merged

2 tasks

squishykid added 2 commits March 31, 2019 16:55

Linter compliance

028ee52

lint++

caeaa44

rohankapoorcom requested changes Apr 1, 2019

View reviewed changes

homeassistant/components/solax/sensor.py Outdated Show resolved Hide resolved

squishykid added 6 commits April 9, 2019 15:26

Merge branch 'dev' of https://github.com/home-assistant/home-assistant …

1c41458

…into solax-inverter

move api communication to external lib

76eb6fb

lint++

ff0af18

requirements

82a6c0c

Merge branch 'dev' of https://github.com/home-assistant/home-assistant …

dc2d1ea

…into solax-inverter # Conflicts: # .coveragerc

Revert "requirements"

ff9a40f

This reverts commit 82a6c0c.

This comment has been minimized.

Sign in to view

potentially?

23ca416

rohankapoorcom reviewed Apr 27, 2019

View reviewed changes

homeassistant/components/solax/sensor.py Outdated Show resolved Hide resolved

rohankapoorcom reviewed Apr 27, 2019

View reviewed changes

homeassistant/components/solax/manifest.json Outdated Show resolved Hide resolved

squishykid added 2 commits May 2, 2019 16:47

Merge branch 'dev' of https://github.com/home-assistant/home-assistant …

b166766

…into solax-inverter

Addressing review comments

f69c5cc

rohankapoorcom reviewed May 4, 2019

View reviewed changes

homeassistant/components/solax/sensor.py Outdated Show resolved Hide resolved

Also update CODEOWNERS

ca43123

Only update sensor state if data has changed

77d24c0

Merge branch 'dev' of https://github.com/home-assistant/home-assistant …

6011f7a

…into solax-inverter

rohankapoorcom approved these changes May 26, 2019

View reviewed changes

rohankapoorcom merged commit 7959c04 into home-assistant:dev May 26, 2019

balloob removed the new-platform label Jun 3, 2019

balloob mentioned this pull request Jun 4, 2019

0.94.0 #24305

Merged

squishykid deleted the solax-inverter branch June 14, 2019 23:39

home-assistant locked as resolved and limited conversation to collaborators Jun 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Solax Inverter Sensor Component #22579

Solax Inverter Sensor Component #22579

squishykid commented Mar 31, 2019 •

edited

homeassistant commented Mar 31, 2019

awarecan commented Apr 4, 2019

squishykid commented Apr 4, 2019

This comment has been minimized.

squishykid commented Apr 11, 2019

rohankapoorcom commented Apr 27, 2019

codecov bot commented May 6, 2019

codecov bot commented May 6, 2019 •

edited

squishykid commented May 12, 2019

rohankapoorcom commented May 26, 2019

MJP-76 commented Jun 6, 2019

kprzeb commented Jun 14, 2019

squishykid commented Jun 15, 2019

MJP-76 commented Jun 18, 2019

kprzeb commented Jun 20, 2019 •

edited by MartinHjelmare

MartinHjelmare commented Jun 20, 2019

Solax Inverter Sensor Component #22579

Solax Inverter Sensor Component #22579

Conversation

squishykid commented Mar 31, 2019 • edited

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

homeassistant commented Mar 31, 2019

awarecan commented Apr 4, 2019

squishykid commented Apr 4, 2019

This comment has been minimized.

squishykid commented Apr 11, 2019

rohankapoorcom commented Apr 27, 2019

codecov bot commented May 6, 2019

Codecov Report

codecov bot commented May 6, 2019 • edited

Codecov Report

squishykid commented May 12, 2019

rohankapoorcom commented May 26, 2019

MJP-76 commented Jun 6, 2019

kprzeb commented Jun 14, 2019

squishykid commented Jun 15, 2019

MJP-76 commented Jun 18, 2019

kprzeb commented Jun 20, 2019 • edited by MartinHjelmare

MartinHjelmare commented Jun 20, 2019

squishykid commented Mar 31, 2019 •

edited

Example entry for `configuration.yaml` (if applicable):

codecov bot commented May 6, 2019 •

edited

kprzeb commented Jun 20, 2019 •

edited by MartinHjelmare