Add Google Assistant garage type #23115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
core
has-tests
integration: google_assistant
small-pr
ghost
added
the
Codecov Report
@@ Coverage Diff @@
## dev #23115 +/- ##
==========================================
+ Coverage 94.09% 94.09% +<.01%
==========================================
Files 452 452
Lines 36795 36802 +7
==========================================
+ Hits 34623 34630 +7
Misses 2172 2172
Continue to review full report at Codecov.
|
pvizeli
reviewed
Apr 15, 2019
balloob
reviewed
Apr 15, 2019
balloob
approved these changes
Apr 15, 2019
elupus
pushed a commit
to elupus/home-assistant
that referenced
this pull request
Apr 16, 2019
* Tests * Add Google Assistant GARAGE type * Update test_trait.py * Key device class by domain * Update smart_home.py
|
Will this change prevent Google from opening my garage door when I say "Hey Google, open all of the shades"? I was about to file an issue on that, but looks like this may resolve that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add new undocumented device types in google assistant. Test with garage type. It only change the blind icon in the app for a generic icon and the type of the device. This doesn't add or substrat any functionality.
Related issue (if applicable): fixes #23076
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: