Broadlink fixup unintended breakage from service refactor #23408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches switch config and is a regression fix
homeassistant
added
cla-signed
has-tests
integration: broadlink
small-pr
ghost
assigned 
|
Hey there @Danielhiversen, mind taking a look at this pull request as its been labeled with a integration ( This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people. |
|
If i want this into a fixup release for current release do i need to do anything special. It's a pointless regression. |
balloob
approved these changes
Apr 25, 2019
pvizeli
pushed a commit
that referenced
this pull request
Apr 26, 2019
* Allow host/ipv6 address for broadlink service This matches switch config and is a regression fix * Restore padding of packets for broadlink * Drop unused import * Fix comment on test
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Restore allowing host for services calls and pad packets
Related issue (if applicable): fixes #18453
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
Documentation added/updated in home-assistant.ioIf the code communicates with devices, web services, or third-party tools:
The manifest file has all fields filled out correctly (example).New dependencies have been added torequirementsin the manifest (example).New dependencies are only imported inside functions that use them (example).New or updated dependencies have been added torequirements_all.txtby runningscript/gen_requirements_all.py.New files were added to.coveragerc.If the code does not interact with devices: