Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix two times creating JWT headers in Push Notifications #23777

Merged
merged 1 commit into from May 9, 2019
Merged

fix two times creating JWT headers in Push Notifications #23777

merged 1 commit into from May 9, 2019

Conversation

pszafer
Copy link
Contributor

@pszafer pszafer commented May 9, 2019

I found bug in my PR: #22988
Two times creating JWT headers.
First time in the method, second time in the code.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

@ghost ghost assigned robbiet480 May 9, 2019
@ghost
Copy link

ghost commented May 9, 2019

Hey there @robbiet480, mind taking a look at this pull request as its been labeled with a integration (html5) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@pszafer pszafer changed the title fix two times creating JWT headers. fix two times creating JWT headers in Push Notifications May 9, 2019
@pszafer pszafer marked this pull request as ready for review May 9, 2019 12:33
@pszafer pszafer requested a review from robbiet480 as a code owner May 9, 2019 12:33
@balloob balloob merged commit 068749b into home-assistant:dev May 9, 2019
@balloob balloob mentioned this pull request Jun 4, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants