Suez water #23844

ooii · 2019-05-13T08:42:21Z

Description:

This component adds a sensor to Home-Assistant. This sensor fetches data from the French water provider Suez.
It gets the following data:

Daily consumption for current month
Daily consumption for previous month
Previous day consumption
Monthly consumption for the last 26 months
Highest monthly consumption
Last year total consumption
Current year total consumption

Example entry for `configuration.yaml` (if applicable):

sensor:
  - platform: suez_water
    username: !secret suez_username
    password: !secret suez_password
    counter_id: 3388776655

counter_id is the water counter id. It can be found on toutsurmoneau.fr users account.

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
Untested files have been added to .coveragerc.

If the code does not interact with devices:

[] Tests have been added to verify that the new code works.

Pull request in home-assistant (if applicable): home-assistant/home-assistant.io#9576

…to suezWater

homeassistant · 2019-05-13T09:04:19Z

Hi @ooii,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

fabaff

The communication with the toutsurmoneau.fr should be handled by a module that is imported -> https://developers.home-assistant.io/docs/en/development_checklist.html

homeassistant/components/suez_water/sensor.py

ooii · 2019-05-17T15:12:16Z

The communication with the toutsurmoneau.fr should be handled by a module that is imported -> https://developers.home-assistant.io/docs/en/development_checklist.html

I'm working on it right now.
I'll update that later.
Thanks.

Co-Authored-By: Fabian Affolter <mail@fabian-affolter.ch>

ooii

Please include an attribution to the source of the data

Sorry but I don't understand what does that mean.

homeassistant/components/suez_water/.coveragerc

MartinHjelmare

Please remove the readme file.

See below for more comments.

.coveragerc

homeassistant/components/suez_water/manifest.json

homeassistant/components/suez_water/sensor.py

…to suezWater Responses to PR home-assistant#23844 comments

homeassistant/components/suez_water/sensor.py

MartinHjelmare · 2019-07-03T15:45:22Z

homeassistant/components/suez_water/sensor.py

+            self._attributes['history'] = {}
+            for item in self.client.attributes['history']:
+                self._attributes[
+                    'history'][item] = self.client.attributes[


What are the items?

Latest months consumption.
I can't know the number of items in advance.

Is each item key the name of the month and the item value is the month consumption in liters?

Please describe the item in more detail.

Sorry, did not see this question.
history will looks like that:

{ "Février 2019": 10109, "Mars 2019": 7553, "Avril 2019": 9003, "Mai 2019": 8844, "Juin 2019": 10472, "Juillet 2019": 4168 }

It seems that history contains last 6 months consumption.

MartinHjelmare · 2019-07-03T15:45:49Z

homeassistant/components/suez_water/sensor.py

+                    item] = self.client.attributes[
+                        'thisMonthConsumption'][item]
+            self._attributes['previousMonthConsumption'] = {}
+            for item in self.client.attributes['previousMonthConsumption']:


What are the items?

Daily previous month consumption.
I can't know the number of items in advance.

MartinHjelmare · 2019-07-03T15:45:57Z

homeassistant/components/suez_water/sensor.py

+                'attribution'] = self.client.attributes[
+                    'attribution']
+            self._attributes['thisMonthConsumption'] = {}
+            for item in self.client.attributes['thisMonthConsumption']:


What are the items?

Daily current month consumption.
I can't know the number of items in advance.

homeassistant/components/suez_water/sensor.py

…ants returned directly, and remove of attribute. Update of .

MartinHjelmare · 2019-07-23T19:08:19Z

Please rebase on latest dev branch to let the build pass.

homeassistant/components/suez_water/sensor.py

MartinHjelmare

Good!

MartinHjelmare · 2019-07-23T22:04:01Z

Can be merged when build passes.

Radar added 5 commits May 10, 2019 15:46

Add suez water sensor

ca3df87

flake8 test

6060924

pylint test

10d465c

edition to fix flake8 and pylint issues

ae64f79

edition to be okay with the musts

5e7542c

homeassistant added cla-error new-integration new-platform integration: suez_water labels May 13, 2019

Farid added 3 commits May 13, 2019 10:57

Added a blank line to __init.py__ for flake8

900a0ba

added blank line for flake8

e46b070

Merge branch 'suezWater' of https://github.com/ooii/home-assistant in…

f43247b

…to suezWater

homeassistant added cla-needed cla-signed and removed cla-needed labels May 13, 2019

changer scan interval from 10 to 720 minutes

764d94b

awarecan added cla-recheck and removed cla-error cla-signed labels May 14, 2019

homeassistant added cla-signed and removed cla-recheck labels May 14, 2019

fabaff requested changes May 17, 2019

View reviewed changes

homeassistant/components/suez_water/sensor.py Outdated Show resolved Hide resolved

homeassistant/components/suez_water/sensor.py Outdated Show resolved Hide resolved

homeassistant/components/suez_water/sensor.py Outdated Show resolved Hide resolved

Radar added 6 commits June 3, 2019 16:22

use of pysuez

3fedfec

bug fix and isort

ee24baa

use of pysuez

74d799e

fixed flake8 and pylint errors

a80391e

update requirements_all.txt

61a9695

added a method to test login/password befire adding device

0f20749

ooii and others added 2 commits June 7, 2019 16:04

Update homeassistant/components/suez_water/sensor.py

a90df5c

Co-Authored-By: Fabian Affolter <mail@fabian-affolter.ch>

Update homeassistant/components/suez_water/sensor.py

65ff9c7

Co-Authored-By: Fabian Affolter <mail@fabian-affolter.ch>

ooii commented Jun 7, 2019

View reviewed changes

homeassistant/components/suez_water/.coveragerc Outdated Show resolved Hide resolved

Radar and others added 6 commits June 7, 2019 22:59

bug fix in check credentials

7878697

flake8 and pylint fixes

ebd5ac1

fix codeowner

a781c95

update requirements_all.txt

37232e3

Merge branch 'dev' into suezWater

8db21b2

Merge branch 'dev' into suezWater

d636f79

home-assistant deleted a comment from homeassistant Jun 25, 2019

MartinHjelmare requested changes Jun 25, 2019

View reviewed changes

MartinHjelmare reviewed Jun 25, 2019

View reviewed changes

homeassistant/components/suez_water/sensor.py Outdated Show resolved Hide resolved

homeassistant/components/suez_water/sensor.py Show resolved Hide resolved

ooii and others added 3 commits July 3, 2019 15:10

Sorted suez_water line

993471f

edition to answer comments from @MartinHjelmare on home-assistant#23844

2db8648

Merge branch 'suezWater' of https://github.com/ooii/home-assistant in…

50e74df

…to suezWater Responses to PR home-assistant#23844 comments

MartinHjelmare reviewed Jul 3, 2019

View reviewed changes

Radar added 3 commits July 3, 2019 18:13

Attribute keys formatting to lowercase snakecase, name and icon const…

af38c6e

…ants returned directly, and remove of attribute. Update of .

pylint edition

445e69d

correction wrong keys in client attributes

d3a2263

MartinHjelmare reviewed Jul 23, 2019

View reviewed changes

homeassistant/components/suez_water/sensor.py Outdated Show resolved Hide resolved

homeassistant/components/suez_water/sensor.py Outdated Show resolved Hide resolved

MartinHjelmare added this to Review in progress in Dev Jul 23, 2019

remove of unnedeed return and move add_entities

1726da1

MartinHjelmare approved these changes Jul 23, 2019

View reviewed changes

MartinHjelmare moved this from Review in progress to Reviewer approved in Dev Jul 23, 2019

MartinHjelmare merged commit 4fb1937 into home-assistant:dev Jul 23, 2019

Dev automation moved this from Reviewer approved to Done Jul 23, 2019

balloob removed the new-platform label Aug 7, 2019

balloob mentioned this pull request Aug 7, 2019

0.97.0 #25756

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Suez water #23844

Suez water #23844

ooii commented May 13, 2019 •

edited

homeassistant commented May 13, 2019

fabaff left a comment

ooii commented May 17, 2019

ooii left a comment

MartinHjelmare left a comment

MartinHjelmare Jul 3, 2019

ooii Jul 3, 2019

MartinHjelmare Jul 4, 2019

ooii Jul 23, 2019

MartinHjelmare Jul 3, 2019

ooii Jul 3, 2019 •

edited

MartinHjelmare Jul 3, 2019

ooii Jul 3, 2019

MartinHjelmare commented Jul 23, 2019

MartinHjelmare left a comment

MartinHjelmare commented Jul 23, 2019

Suez water #23844

Suez water #23844

Conversation

ooii commented May 13, 2019 • edited

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

homeassistant commented May 13, 2019

fabaff left a comment

Choose a reason for hiding this comment

ooii commented May 17, 2019

ooii left a comment

Choose a reason for hiding this comment

MartinHjelmare left a comment

Choose a reason for hiding this comment

MartinHjelmare Jul 3, 2019

Choose a reason for hiding this comment

ooii Jul 3, 2019

Choose a reason for hiding this comment

MartinHjelmare Jul 4, 2019

Choose a reason for hiding this comment

ooii Jul 23, 2019

Choose a reason for hiding this comment

MartinHjelmare Jul 3, 2019

Choose a reason for hiding this comment

ooii Jul 3, 2019 • edited

Choose a reason for hiding this comment

MartinHjelmare Jul 3, 2019

Choose a reason for hiding this comment

ooii Jul 3, 2019

Choose a reason for hiding this comment

MartinHjelmare commented Jul 23, 2019

MartinHjelmare left a comment

Choose a reason for hiding this comment

MartinHjelmare commented Jul 23, 2019

ooii commented May 13, 2019 •

edited

Example entry for `configuration.yaml` (if applicable):

ooii Jul 3, 2019 •

edited