Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove icon() #24280

Merged
merged 1 commit into from Jun 3, 2019
Merged

Remove icon() #24280

merged 1 commit into from Jun 3, 2019

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jun 3, 2019

Description:

It's a binary sensor and not a sensor.

Supersede #24171

Example entry for configuration.yaml (if applicable):

binary_sensor:
  - platform: meteoalarm
    country: 'NL'
    province: 'Groningen'

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

@ghost
Copy link

ghost commented Jun 3, 2019

Hey there @rolfberkenbosch, mind taking a look at this pull request as its been labeled with a integration (meteoalarm) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@pvizeli pvizeli merged commit 7fd2e67 into dev Jun 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the meteoalarm-icon branch June 3, 2019 14:31
@balloob balloob mentioned this pull request Jun 26, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants