Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ATTR_FORECAST_PRECIPITATION option #24308

Merged
merged 2 commits into from Jun 8, 2019
Merged

Add ATTR_FORECAST_PRECIPITATION option #24308

merged 2 commits into from Jun 8, 2019

Conversation

rolfberkenbosch
Copy link
Contributor

Description:

I have added the ATTR_FORECAST_PRECIPITATION option to the weather.py file from buienradar, because the pypi lib of buienradar is also supporting this.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@andrewsayre andrewsayre merged commit b5ada3b into home-assistant:dev Jun 8, 2019
@rolfberkenbosch rolfberkenbosch deleted the dev-buienradar branch June 8, 2019 13:53
@balloob balloob mentioned this pull request Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants