Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meteofrance fix 24244 #24315

Merged
merged 3 commits into from
Jun 6, 2019
Merged

Conversation

victorcerutti
Copy link
Contributor

@victorcerutti victorcerutti commented Jun 5, 2019

Description:

Some elements went missing on meteo-france website, I corrected the package
Related issue : fixes #24244

Example entry for configuration.yaml (if applicable):

meteo_france:
  - city: 'Rouen'

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@cgarwood cgarwood merged commit 859ae2f into home-assistant:dev Jun 6, 2019
@balloob balloob mentioned this pull request Jun 26, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
* Update meteofrance package version

Fix home-assistant#24244

* Add code owner to manifest

* Update CODEOWNERS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

meteo_france crashes at start
4 participants