Add service to update core location #24328
Conversation
homeassistant
added
cla-signed
core
has-tests
integration: homeassistant
small-pr
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration ( This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people. |
| """Test setting the location.""" | ||
| await async_setup_component(hass, 'homeassistant', {}) | ||
| events = async_capture_events(hass, EVENT_CORE_CONFIG_UPDATE) | ||
| assert hass.config.latitude != 10 |
There was a problem hiding this comment.
I'm confused on why you're asserting it's not 10 and 20... shouldn't this either assert it's some other value than what is being set OR assert that it's NOT 30 and 40?
There was a problem hiding this comment.
You are right, I should have done not 30 and 40, just to make sure my update works.
Hi @balloob ... thanks a lot for this update! I'm using HA in an RV as well. I'm wondering, can set_location be expanded to allow setting the time zone and elevation as well? |
|
Thank you for reaching out. We use GitHub for tracking issues, not for providing support. If you are in need of support, you should try our Community Forum or join our Discord chat server. You are more likely to get the answer you are looking for in those places. Thanks! 👍 |
Description:
Add a service to update the location of Home Assistant in the core config. This will make it easier to use Home Assistant in RVs.
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: