Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad error logs in Axis component #24376

Merged

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Jun 7, 2019

Breaking Change:

Description:

People are anxious about an error message (which isn't really an error message). I have removed it in favour of a debug message

Related issue (if applicable): fixes #24366

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned Kane610 Jun 7, 2019
@ghost
Copy link

ghost commented Jun 7, 2019

Hey there @Kane610, mind taking a look at this pull request as its been labeled with a integration (axis) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@Kane610 Kane610 added this to the 0.94.1 milestone Jun 7, 2019
@Kane610 Kane610 changed the title Bump dependency Bump Axis dependency Jun 7, 2019
@Kane610 Kane610 changed the title Bump Axis dependency Fix bad error logs in Axis component Jun 7, 2019
@Kane610
Copy link
Member Author

Kane610 commented Jun 7, 2019

Much obliged @andrewsayre

@andrewsayre andrewsayre merged commit 1647eba into home-assistant:dev Jun 7, 2019
@Kane610 Kane610 deleted the axis-remove-ioports-errors-from-logs branch June 7, 2019 19:23
balloob pushed a commit that referenced this pull request Jun 8, 2019
@balloob balloob mentioned this pull request Jun 8, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Axis root.IOPort errors in logs
4 participants