Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check cloud trusted proxies #24395

Merged
merged 1 commit into from
Jun 8, 2019
Merged

Check cloud trusted proxies #24395

merged 1 commit into from
Jun 8, 2019

Conversation

balloob
Copy link
Member

@balloob balloob commented Jun 8, 2019

Description:

Besides trusted networks, also check trusted proxies.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.94.1 milestone Jun 8, 2019
@balloob balloob requested a review from a team as a code owner June 8, 2019 05:56
@ghost
Copy link

ghost commented Jun 8, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (http) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@ghost
Copy link

ghost commented Jun 8, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (cloud) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@balloob balloob merged commit f77514c into dev Jun 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the cloud-trusted-proxies branch June 8, 2019 06:09
balloob added a commit that referenced this pull request Jun 8, 2019
@balloob
Check cloud trusted proxies (#24395)
14066df
@balloob balloob mentioned this pull request Jun 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cherry-picked cla-signed core has-tests integration: cloud integration: http
Projects
None yet
Milestone
0.94.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@balloob @homeassistant