-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add surepetcare component #24426
Add surepetcare component #24426
Conversation
Maybe wait until 1. Aug., this code is not Python 3.5 compatible. |
Very eager to try this integration. Possible to pull it out to as a custom component ? |
Sure, just copy the |
I tried this config: surepetcare: However its not updating at all. I see that you are using: But it feels like surepy is very slow at updating, or even updating at all? Am I doing something wrong here @benleb ? |
Visit https://surepetcare.io while your browsers dev/js console is open. The household ID will be visible there multiple times, searching for "household" gets you to your ID 👍 |
The component is working, and I get all the sensors in Hass.io but they are not updating... |
Did you wait a little? The scan_interval defaults to 3 minutes as Sure Petcare explicitly does not like/want that their API is used this way. I have talk to them a few times and it was really disappointing... So, you can change the update interval via the edit ah sorry, my fault... will fix this today or tomorrow :D |
fixed, sorry! ✌️ |
Thanks for the great work @benleb ! Would be great to have this integrated once Python 3.5 support is dropped later this year. |
Great work! Got it to work using your instruction. Thanks! |
Please rebase on latest dev branch too. |
@benleb are you planning to continue here? |
When I upgrade from 98.4 to 98.5 this breaks for me. Has anyone else encountered the same issue? |
Thanks - I think my problem was that I wasn't patient enough. My pet entity in HA only seems to appear after 10-15 minutes following boot - I think sometimes it struggles on first boot. |
@MartinHjelmare yes, gimme some days ;) @Groodles I did not implement any writing as this is an undocumented API which we have no permission to use ;) So to prevent any crazy surprises for us or our cats, just reading for now ;) |
How many days are "some"? 😸 🤔 |
Ten more ;) my masters thesis is in its final phase now and has precedence :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're getting close. It's mostly clean up left but two things about the library should change. See below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you're ready, please remove the commented code.
Remember to update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Great job from you @MartinHjelmare! Thanks for your awesome work and reviews here on github! 👍 |
Description:
Second edition of #22155. Adds a basic component for the Sure Petcare cat and pet flaps. Most important things like lock state of a flap and location of pets is implemented, will eventually be enhanced if component gets accepted.
Related issue (if applicable): https://community.home-assistant.io/t/sureflap-connect-pet-door/41488/54
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9590
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: