Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sun listener to adapt to core config updates #24464

Merged
merged 2 commits into from Jun 10, 2019
Merged

Sun listener to adapt to core config updates #24464

merged 2 commits into from Jun 10, 2019

Conversation

balloob
Copy link
Member

@balloob balloob commented Jun 10, 2019

Description:

This makes the sun listener adapt to core config changes.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from a team as a code owner June 10, 2019 21:23
@balloob balloob requested a review from Swamp-Ig June 10, 2019 21:25
@balloob balloob added this to the 0.94.2 milestone Jun 10, 2019
@balloob balloob merged commit 236c5de into dev Jun 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the sun-listener branch June 10, 2019 23:05
balloob added a commit that referenced this pull request Jun 10, 2019
@balloob
Sun listener to adapt to core config updates (#24464)
bd80346 
* Adaptable sun listener

* Lint
@balloob balloob mentioned this pull request Jun 10, 2019
Merged
Swamp-Ig
Swamp-Ig reviewed Jun 10, 2019
View reviewed changes
Copy link
Contributor

@Swamp-Ig Swamp-Ig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
@balloob @alandtse
Sun listener to adapt to core config updates (home-assistant#24464)
5986e1e 
* Adaptable sun listener

* Lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swamp-Ig Swamp-Ig Swamp-Ig left review comments

Assignees
No one assigned
Labels
cherry-picked cla-signed core
Projects
None yet
Milestone
0.94.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@balloob @Swamp-Ig @homeassistant