Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sleepiq single sleeper crash #24941

Merged
merged 10 commits into from Jul 7, 2019
Merged

Sleepiq single sleeper crash #24941

merged 10 commits into from Jul 7, 2019

Conversation

qypea
Copy link
Contributor

@qypea qypea commented Jul 4, 2019

Description:

Related issue (if applicable): fixes #24795

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

sleepiq:
  username: REDACTED
  password: !secret sleepiq

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

qypea added 2 commits July 1, 2019 06:00
Fixes crash when working with a single sleeper.
These happen if no sleeper is defined for a side of the bed. Don't
create sensors for null sides; they'll crash every time we try to use
them.
@homeassistant
Copy link
Contributor

Hi @qypea,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@qypea qypea marked this pull request as ready for review July 4, 2019 13:07
tests/components/sleepiq/test_init.py Outdated Show resolved Hide resolved
tests/components/sleepiq/test_init.py Outdated Show resolved Hide resolved
@pvizeli pvizeli merged commit 628e12c into home-assistant:dev Jul 7, 2019
@lock lock bot locked and limited conversation to collaborators Jul 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sleepiq error with one sleeper
3 participants