Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade mypy to 0.711, drop no longer needed workarounds #24998

Merged
merged 1 commit into from Jul 7, 2019
Merged

Upgrade mypy to 0.711, drop no longer needed workarounds #24998

merged 1 commit into from Jul 7, 2019

Conversation

scop
Copy link
Member

@scop scop commented Jul 6, 2019

Description:

https://mypy-lang.blogspot.com/2019/06/mypy-0711-released.html

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@scop scop requested a review from a team as a code owner July 6, 2019 21:22
@homeassistant homeassistant added core small-pr PRs with less than 30 lines. cla-signed labels Jul 6, 2019
@MartinHjelmare MartinHjelmare merged commit e8a5306 into home-assistant:dev Jul 7, 2019
@scop scop deleted the upgrade-mypy branch July 7, 2019 07:51
@lock lock bot locked and limited conversation to collaborators Jul 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@amelchio amelchio amelchio approved these changes

Assignees
No one assigned
Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@scop @MartinHjelmare @amelchio @homeassistant