[climate] Add water_heater to evohome #25035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
pvizeli
reviewed
Jul 9, 2019
pvizeli
reviewed
Jul 9, 2019
9 tasks
zxdavb
changed the title
zxdavb
changed the title
balloob
reviewed
Jul 10, 2019
balloob
reviewed
Jul 10, 2019
balloob
reviewed
Jul 10, 2019
balloob
reviewed
Jul 11, 2019
pvizeli
reviewed
Jul 11, 2019
|
@balloob I'm not intending to make any more changes to this, if you'd like to merge it. I has essentially passed QI. |
balloob
approved these changes
Jul 12, 2019
|
Woot! 💐 Thanks everyone! |
balloob
pushed a commit
that referenced
this pull request
Jul 12, 2019
* initial commit * refactor for sync * minor tweak * refactor convert code * fix regression * remove bad await * de-lint * de-lint 2 * address edge case - invalid tokens * address edge case - delint * handle no schedule * improve support for RoundThermostat * tweak logging * delint * refactor for greatness * use time_zone: for state attributes * small tweak * small tweak 2 * have datetime state attributes as UTC * have datetime state attributes as UTC - delint * have datetime state attributes as UTC - tweak * missed this - remove * de-lint type hint * use parse_datetime instead of datetime.strptime) * remove debug code * state atrribute datetimes are UTC now * revert * de-lint (again) * tweak type hints * de-lint (again, again) * tweak type hints * Convert datetime closer to sending it out
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
Description:
Adds water_heater to evohome - this is required to support those moving from honeywell, which has deprecated EU support.
Also switches a lot of async to sync.
Also addresses:
KeyErrorException for systems with DHW controllersRelated issue (if applicable): fixes #
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: