Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Withings support #25154

Merged
merged 9 commits into from Aug 31, 2019
Merged

Add Withings support #25154

merged 9 commits into from Aug 31, 2019

Conversation

vangorra
Copy link
Contributor

Reopening #21625

Description:

Adding support for connecting to Withings apis to integrate health data into home assistant.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8816

Example entry for configuration.yaml (if applicable):

# Example configuration.yaml entry
withings:
    client_id: <client id from previous step>
    client_secret: <consumer secret from previous step>
    profiles: 
        - <name of user profile>

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@vangorra vangorra mentioned this pull request Jul 15, 2019
Closed
9 tasks
@balloob
Copy link
Member

balloob commented Jul 15, 2019

Did you address my comments from the previous PR?

@vangorra
Copy link
Contributor Author

Yes. The config flow changes were especially welcomed as it simplified the code.

@vangorra vangorra mentioned this pull request Jul 16, 2019
Merged
2 tasks
@MartinHjelmare MartinHjelmare added this to Review in progress in Dev Jul 23, 2019
@vangorra vangorra requested a review from a team August 11, 2019 15:27
@vangorra vangorra requested a review from a team as a code owner August 11, 2019 15:27
@homeassistant

This comment has been minimized.

Sign in to view
@homeassistant

This comment has been minimized.

Sign in to view
@vangorra
Copy link
Contributor Author

I didn't realize changing my github email would be so messy. At any rate the PR is updated and addresses the latest feedback.

@MartinHjelmare
Copy link
Member

The branch isn't clean. It has lots of unrelated commits. Please rebase and clean the branch, or open a new PR from a clean branch.

@MartinHjelmare MartinHjelmare removed the request for review from a team August 12, 2019 18:43
MartinHjelmare
MartinHjelmare reviewed Aug 12, 2019
View reviewed changes
homeassistant/components/withings/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/withings/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/withings/__init__.py Show resolved Hide resolved
homeassistant/components/withings/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/withings/__init__.py Outdated Show resolved Hide resolved
@project-bot project-bot bot moved this from Review in progress to Needs review in Dev Aug 12, 2019
@MartinHjelmare MartinHjelmare moved this from Needs review to Review in progress in Dev Aug 12, 2019
MartinHjelmare
MartinHjelmare reviewed Aug 18, 2019
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge after these comments are addressed.

homeassistant/components/withings/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/withings/strings.json Outdated Show resolved Hide resolved
homeassistant/components/withings/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/withings/common.py Outdated Show resolved Hide resolved
homeassistant/components/withings/common.py Outdated Show resolved Hide resolved
MartinHjelmare
MartinHjelmare approved these changes Aug 31, 2019
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Dev automation moved this from Review in progress to Reviewer approved Aug 31, 2019
@MartinHjelmare MartinHjelmare merged commit 614cf74 into home-assistant:dev Aug 31, 2019
Dev automation moved this from Reviewer approved to Done Aug 31, 2019
@lock lock bot locked and limited conversation to collaborators Sep 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cla-signed core has-tests integration: withings new-integration
Projects
Dev
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vangorra @balloob @homeassistant @MartinHjelmare