Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vendor support for vorwerk robots and fix zone retrieval #25200

Merged

Conversation

dshokouhi
Copy link
Member

@dshokouhi dshokouhi commented Jul 17, 2019

Breaking Change:

As the vendor default remains as neato this is not a breaking change for neato users.

Description:

This PR has a few small changes:

Related issue (if applicable): fixes #21796

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9882

Example entry for configuration.yaml (if applicable):

neato:
  username: username
  password: password
  vendor: vorwerk

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

homeassistant/components/neato/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/neato/vacuum.py Outdated Show resolved Hide resolved
@dshokouhi
Copy link
Member Author

Thank you for your review @MartinHjelmare :)

@dshokouhi
Copy link
Member Author

Forgot to mention but we can also close this feature request in the forum once we merge this :)

https://community.home-assistant.io/t/please-integrate-vorwerk-vr200-vacuum-cleaner-robot-in-home-assistant/92042/4

@dshokouhi dshokouhi mentioned this pull request Jul 18, 2019
3 tasks
@balloob balloob merged commit 32e89dc into home-assistant:dev Jul 18, 2019
@dshokouhi dshokouhi deleted the add_vendor_support_and_fix_zone_retrieval branch July 18, 2019 17:24
@lock lock bot locked and limited conversation to collaborators Jul 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zone cleaning on Neato Botvac D7 always uses first map ID
4 participants