Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniFi - handle that device.last_seen can be None #25690

Merged

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Aug 4, 2019

Breaking Change:

Description:

Device.last_seen can be None a short period of time after a controller restarts

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@Kane610 Kane610 added this to the 0.97.0 milestone Aug 4, 2019
@Kane610 Kane610 self-assigned this Aug 4, 2019
@probot-home-assistant probot-home-assistant bot added the small-pr PRs with less than 30 lines. label Aug 4, 2019
@project-bot project-bot bot added this to Needs review in Dev Aug 4, 2019
@Kane610 Kane610 merged commit 5a90b49 into home-assistant:dev Aug 4, 2019
Dev automation moved this from Needs review to Done Aug 4, 2019
@Kane610 Kane610 deleted the unifi-device-tracker-last-seen-nonetype branch August 4, 2019 14:12
@lock lock bot locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants