Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run flake8 on pre-commit #26028

Merged
merged 1 commit into from Aug 18, 2019
Merged

Run flake8 on pre-commit #26028

merged 1 commit into from Aug 18, 2019

Conversation

scop
Copy link
Member

@scop scop commented Aug 17, 2019

Description:

flake8 runs sufficiently fast so it can be run on pre-commit.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

@project-bot project-bot bot added this to Needs review in Dev Aug 17, 2019
@probot-home-assistant probot-home-assistant bot added the small-pr PRs with less than 30 lines. label Aug 17, 2019
Dev automation moved this from Needs review to Reviewer approved Aug 18, 2019
@balloob balloob merged commit 4bcee4f into home-assistant:dev Aug 18, 2019
Dev automation moved this from Reviewer approved to Done Aug 18, 2019
@scop scop deleted the pre-commit-flake8 branch August 18, 2019 06:43
@lock lock bot locked and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@scop @balloob @homeassistant