Docker ADR #26085
Merged
Docker ADR #26085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
integration: tensorflow
small-pr
frenck
approved these changes
Aug 20, 2019
This comment has been minimized.
This comment has been minimized.
frenck
reviewed
Aug 20, 2019
frenck
requested changes
Aug 20, 2019
There was a problem hiding this comment.
Architectures for manifest must match those from GO:
https://golang.org/doc/install/source#environment
So we have incorrect ones now. Use variants for specific CPU's
frenck
reviewed
Aug 20, 2019
frenck
approved these changes
Aug 20, 2019
balloob
reviewed
Aug 20, 2019
| @@ -1,64 +0,0 @@ | |||
| # Dockerfile for development | |||
There was a problem hiding this comment.
Let's keep a dev dockerfile. Not everyone using VSCode with dev containers yet :)
balloob
approved these changes
Aug 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement https://github.com/home-assistant/architecture/blob/master/adr/0006-docker-images.md
Note: I removed the vagrant because they run with python35 and look like there is no maintainer around. I think also we should have such stuff, not in the main repository.