Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoolMaster: Change auto to heat_cool #26144

Merged
merged 1 commit into from Aug 23, 2019

Conversation

OnFreund
Copy link
Contributor

@OnFreund OnFreund commented Aug 22, 2019

Breaking Change:

The supported_modes configuration will now reject auto and accept heat_cool instead. If you're not using CoolMaster, or are using the default supported modes, or did not have auto in your supported modes, this does not affect you.

Description:

Changing the auto mode to a heat_cool mode in CoolMaster to better reflect what it does.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10209

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

@probot-home-assistant probot-home-assistant bot added integration: coolmaster small-pr PRs with less than 30 lines. labels Aug 22, 2019
@project-bot project-bot bot added this to Needs review in Dev Aug 22, 2019
OnFreund added a commit to OnFreund/home-assistant.io that referenced this pull request Aug 22, 2019
@balloob
Copy link
Member

balloob commented Aug 22, 2019

Heat/Cool means that there is a range (upper/lower set points), and the thermostat will automatically cool/heat if the current temperature goes out of this range.

Coolmaster does not seem to have the notion of temperature ranges so I am not sure if heat_cool is the right mode here ?

@OnFreund
Copy link
Contributor Author

I may have misunderstood, but based on previous discussions I was under the impression that auto was for algorithmically determined operations, whereas heat_cool was for automatic heating or cooling based on temperature, whether a range or a single temperature (which is basically an implicit range since there's a tolerance both ways).
If that's not the case, I'm more than happy to close this PR.

@MartinHjelmare MartinHjelmare moved this from Needs review to Review in progress in Dev Aug 23, 2019
@OnFreund
Copy link
Contributor Author

@balloob see here: home-assistant/architecture#260 (comment)

If your thermostat is on a schedule, it's auto. If it's temporarily overridden to a range, it's heat cool.

In this case it's neither, but seems to be closer to a temp range than to a schedule.

Dev automation moved this from Review in progress to Reviewer approved Aug 23, 2019
@pvizeli pvizeli merged commit 1efa29d into home-assistant:dev Aug 23, 2019
Dev automation moved this from Reviewer approved to Done Aug 23, 2019
@pvizeli pvizeli added this to the 0.98 milestone Aug 23, 2019
@OnFreund OnFreund deleted the auto_to_heat_cool branch August 23, 2019 16:18
@lock lock bot locked and limited conversation to collaborators Aug 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants