Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci device-tracker dependency fix #26215

Merged
merged 2 commits into from Aug 27, 2019
Merged

Conversation

flowolf
Copy link
Contributor

@flowolf flowolf commented Aug 26, 2019

fixes issue #25758

Description:

bugfix for missing dependency.

Related issue (if applicable): fixes #25758

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@probot-home-assistant probot-home-assistant bot added integration: luci merging-to-master This PR is merging into the RC branch and should probably change the branch to `dev`. small-pr PRs with less than 30 lines. labels Aug 26, 2019
@project-bot project-bot bot added this to Needs review in Dev Aug 26, 2019
@codecov
Copy link

codecov bot commented Aug 26, 2019

Codecov Report

Merging #26215 into dev will increase coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #26215      +/-   ##
==========================================
+ Coverage   94.02%   94.35%   +0.33%     
==========================================
  Files         551      552       +1     
  Lines       42605    46059    +3454     
==========================================
+ Hits        40060    43461    +3401     
- Misses       2545     2598      +53
Impacted Files Coverage Δ
...omeassistant/components/automation/time_pattern.py 93.75% <0%> (-1.71%) ⬇️
homeassistant/components/http/cors.py 95.12% <0%> (-1.55%) ⬇️
homeassistant/components/switch/light.py 91.95% <0%> (-1.03%) ⬇️
homeassistant/components/automation/litejet.py 96.55% <0%> (-1.01%) ⬇️
...meassistant/components/automation/numeric_state.py 97.59% <0%> (-0.66%) ⬇️
...eassistant/components/homekit_controller/sensor.py 98.6% <0%> (-0.27%) ⬇️
homeassistant/components/mqtt/discovery.py 97.82% <0%> (-0.18%) ⬇️
homeassistant/helpers/entity_registry.py 99.17% <0%> (-0.17%) ⬇️
homeassistant/components/unifi/controller.py 98.46% <0%> (-0.16%) ⬇️
homeassistant/components/unifi/device_tracker.py 90.13% <0%> (-0.15%) ⬇️
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03cfe72...cd0e8ec. Read the comment docs.

@fabaff fabaff changed the base branch from master to dev August 26, 2019 22:17
@fabaff fabaff removed the merging-to-master This PR is merging into the RC branch and should probably change the branch to `dev`. label Aug 26, 2019
Dev automation moved this from Needs review to Reviewer approved Aug 26, 2019
@andrewsayre andrewsayre added this to the 0.98 milestone Aug 27, 2019
@andrewsayre andrewsayre merged commit c185c01 into home-assistant:dev Aug 27, 2019
Dev automation moved this from Reviewer approved to Done Aug 27, 2019
@lock lock bot locked and limited conversation to collaborators Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

OpenWRT (luci) error on 0.97.0
6 participants