Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add light platform to iaqualink integration #26484

Merged
merged 3 commits into from Sep 9, 2019

Conversation

flz
Copy link
Contributor

@flz flz commented Sep 6, 2019

Description:

Add light platform to iaqualink integration. Supports brightness and effects when available.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10165 (documentation is for complete integration, only climate platform has landed yet).

Example entry for configuration.yaml (if applicable):

iaqualink:
    username: USERNAME
    password: PASSWORD

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@project-bot project-bot bot added this to Needs review in Dev Sep 6, 2019
@MartinHjelmare MartinHjelmare changed the title Add light platform to iaqualink integration. Add light platform to iaqualink integration Sep 6, 2019
Dev automation moved this from Needs review to Review in progress Sep 6, 2019
homeassistant/components/iaqualink/light.py Outdated Show resolved Hide resolved
homeassistant/components/iaqualink/light.py Outdated Show resolved Hide resolved
homeassistant/components/iaqualink/light.py Outdated Show resolved Hide resolved
homeassistant/components/iaqualink/light.py Outdated Show resolved Hide resolved
homeassistant/components/iaqualink/light.py Outdated Show resolved Hide resolved
homeassistant/components/iaqualink/light.py Outdated Show resolved Hide resolved
Dev automation moved this from Review in progress to Reviewer approved Sep 9, 2019
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare
Copy link
Member

Can be merged when build passes.

@MartinHjelmare
Copy link
Member

Let's make any further changes, as discussed, in another PR.

@MartinHjelmare MartinHjelmare merged commit 3c629db into home-assistant:dev Sep 9, 2019
Dev automation moved this from Reviewer approved to Done Sep 9, 2019
@flz flz deleted the iaqualink-light branch September 10, 2019 20:19
@lock lock bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants