New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add availability_template to Template Sensor platform #26516
Add availability_template to Template Sensor platform #26516
Conversation
Not sure why the coverage is failing here as my changes have improved coverage..?? |
This PR and #25918 seem to implement the same feature but in slightly different ways. |
Hey @MartinHjelmare , Yes it does. I mentioned that to the @Limych in tin his PR when I already had my original 'too big' pull request that added this feature to all the template components (#25918 (comment)).. But it seems he just pressed on anyway. |
@MartinHjelmare he implements this on every template, not only sensor. Of curse, they need to adjust somethings bug after the experience of this review, he can fix the others and we have a complete solution. |
Yes. Should we close the other PR? |
Set the available around the state render like the other PR. Is important that the available is false if the state is Unknown. And I don't think you need a const for After you address that comments, we can merge it 👍 good work |
OK. Will check that out.. |
@pvizeli please check if this is what you mean and I will update to the other PRs. |
Now you can address other PRs too |
@pvizeli Thanks. |
Breaking Change:
Not a Breaking change
Description:
This PR adds an
availability_template
option to Template Sensor platform.By defining the
availability_template
theavailability
of a Template Sensor can be controlled using a template.As Template Components rely on other component states, (i.e. they do not have state themselves) it would be useful to also be able to control when a component is unavailable. e.g. when a component that the template component relies on to function becomes 'unavailable' it would be useful to be able to mark the template component as 'unavailable' also.
If the
availability_template
is not configured, the device will always be 'available' (default behavior)If the
availability_template
is configured, the device will be 'available' if the template returnstrue
or 'unavailable' if the template returns any other value.Closes #25918
Docs PR:
home-assistant/home-assistant.io#10308
Example entry for
configuration.yaml
(if applicable):For a Template Sensor platform component that requires a 'switch.some_sensor' to be available to operate:
Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
..coveragerc
.If the code does not interact with devices: