Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deCONZ - battery sensor instead of battery attribute #26591

Merged
merged 8 commits into from Sep 14, 2019
Merged

deCONZ - battery sensor instead of battery attribute #26591

merged 8 commits into from Sep 14, 2019

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Sep 11, 2019 •
edited

Breaking Change:

Standardizes battery sensor unique id to the serial number of device + battery.
Entity attribute battery level will no longer be available, this will instead be exposed as a separate entity just as with remotes previously.

Description:

Move battery attribute to a standalone sensor per physical device

Related issue (if applicable): fixes Kane610/deconz#42

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@Kane610 Kane610 self-assigned this Sep 11, 2019
@probot-home-assistant probot-home-assistant bot added the small-pr PRs with less than 30 lines. label Sep 11, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 11, 2019
@MartinHjelmare MartinHjelmare moved this from Needs review to Incoming in Dev Sep 12, 2019
@Kane610 Kane610 marked this pull request as ready for review September 12, 2019 20:23
@MartinHjelmare MartinHjelmare moved this from Incoming to Needs review in Dev Sep 13, 2019
@Kane610 Kane610 force-pushed the deconz-battery-sensor branch 2 times, most recently from 7493dc6 to f8a69ac Compare September 14, 2019 11:12
@Kane610
Copy link
Member Author

Kane610 commented Sep 14, 2019

@MartinHjelmare any additional comments?

MartinHjelmare
MartinHjelmare approved these changes Sep 14, 2019
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Dev automation moved this from Needs review to Reviewer approved Sep 14, 2019
@Kane610
Copy link
Member Author

Kane610 commented Sep 14, 2019

Awesome, thanks @MartinHjelmare

@Kane610 Kane610 merged commit 41c9ed5 into home-assistant:dev Sep 14, 2019
Dev automation moved this from Reviewer approved to Done Sep 14, 2019
@Kane610 Kane610 deleted the deconz-battery-sensor branch September 14, 2019 17:15
@lock lock bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

@Kane610 Kane610

Labels
cla-signed integration: deconz small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Battery levels as own entities
3 participants
@Kane610 @MartinHjelmare @homeassistant