Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Solax Library to 0.2.2 #26705

Merged
merged 6 commits into from Sep 19, 2019
Merged

Update Solax Library to 0.2.2 #26705

merged 6 commits into from Sep 19, 2019

Conversation

squishykid
Copy link
Contributor

@squishykid squishykid commented Sep 18, 2019 •
edited

Description:

Example entry for configuration.yaml (if applicable):

  - platform: solax
    ip_address: '192.168.1.1
    port: 8080

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@probot-home-assistant probot-home-assistant bot added integration: solax small-pr PRs with less than 30 lines. labels Sep 18, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 18, 2019
This was referenced Sep 18, 2019
Merged
Closed
Dev automation moved this from Needs review to Review in progress Sep 18, 2019
MartinHjelmare
MartinHjelmare requested changes Sep 18, 2019
View reviewed changes
homeassistant/components/solax/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/solax/sensor.py Outdated Show resolved Hide resolved
@squishykid squishykid changed the title Update Solax Library to 0.2.1 Update Solax Library to 0.2.2 Sep 19, 2019
Dev automation moved this from Review in progress to Reviewer approved Sep 19, 2019
MartinHjelmare
MartinHjelmare approved these changes Sep 19, 2019
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pvizeli pvizeli merged commit 0e201fd into home-assistant:dev Sep 19, 2019
Dev automation moved this from Reviewer approved to Done Sep 19, 2019
@lock lock bot locked and limited conversation to collaborators Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pvizeli pvizeli pvizeli left review comments

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cla-signed integration: solax small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Solax Sensor Error
4 participants
@squishykid @MartinHjelmare @pvizeli @homeassistant