Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use device_tracker latest state after reboot hass #26926

Closed
wants to merge 2 commits into from

Conversation

zhumuht
Copy link
Contributor

@zhumuht zhumuht commented Sep 26, 2019

Description:

after reboot hass, try to reload last device_tracker state from database if device tracker entity not exists in .storage/core.restore_state

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

@project-bot project-bot bot added this to Needs review in Dev Sep 26, 2019
@MartinHjelmare MartinHjelmare changed the title Use device_tracker lastest state after reboot hass Use device_tracker latest state after reboot hass Sep 26, 2019
@frenck
Copy link
Member

frenck commented Nov 20, 2019

Hi there @zhumuht!

The builds on this PR have failed, and in the meantime, a merge conflict has appeared. Are you planning on moving this PR forward?

@MartinHjelmare
Copy link
Member

I suggest we close this PR. We shouldn't rely on the db to restore state.

@balloob balloob closed this Nov 26, 2019
Dev automation moved this from Needs review to Cancelled Nov 26, 2019
@balloob
Copy link
Member

balloob commented Nov 26, 2019

I agree.

@balloob
Copy link
Member

balloob commented Nov 26, 2019

With the new approach, it's up to the integrations to decide how to be restored.

@lock lock bot locked and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Cancelled
Development

Successfully merging this pull request may close these issues.

None yet

5 participants