Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plex external config flow #26936

Merged
merged 15 commits into from Oct 1, 2019

Conversation

jjlawren
Copy link
Contributor

@jjlawren jjlawren commented Sep 26, 2019

Description:

Instead of prompting a user to provide an existing token, will redirect them to the plex.tv website to complete authentication and will obtain a token on their behalf with an OAuth-like process. Relies on new library plexauth.

This new auth method has the added benefit of showing a separate "Home Assistant" authorized device on the Plex account, instead of the legacy method of hijacking an existing authenticated device's token.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10462

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@MartinHjelmare MartinHjelmare added this to Needs review in Dev Sep 27, 2019
Dev automation moved this from Needs review to Review in progress Sep 27, 2019
@MartinHjelmare MartinHjelmare added the second-opinion-wanted Add this label when a reviewer needs a second opinion from another member. label Sep 27, 2019
@project-bot project-bot bot moved this from Review in progress to Second opinion wanted in Dev Sep 27, 2019
homeassistant/components/plex/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/plex/config_flow.py Show resolved Hide resolved
homeassistant/components/plex/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/plex/config_flow.py Show resolved Hide resolved
homeassistant/components/plex/config_flow.py Outdated Show resolved Hide resolved
tests/components/plex/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/plex/test_config_flow.py Outdated Show resolved Hide resolved
@MartinHjelmare MartinHjelmare removed the second-opinion-wanted Add this label when a reviewer needs a second opinion from another member. label Oct 1, 2019
@MartinHjelmare MartinHjelmare moved this from Second opinion wanted to Review in progress in Dev Oct 1, 2019
Dev automation moved this from Review in progress to Reviewer approved Oct 1, 2019
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare MartinHjelmare merged commit 571ab5a into home-assistant:dev Oct 1, 2019
Dev automation moved this from Reviewer approved to Done Oct 1, 2019
@jjlawren jjlawren deleted the plex_external_auth branch October 1, 2019 15:46
@lock lock bot locked and limited conversation to collaborators Oct 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants