New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plex external config flow #26936
Merged
MartinHjelmare
merged 15 commits into
home-assistant:dev
from
jjlawren:plex_external_auth
Oct 1, 2019
Merged
Plex external config flow #26936
MartinHjelmare
merged 15 commits into
home-assistant:dev
from
jjlawren:plex_external_auth
Oct 1, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jjlawren
commented
Sep 27, 2019
MartinHjelmare
requested changes
Sep 27, 2019
MartinHjelmare
added
the
second-opinion-wanted
Add this label when a reviewer needs a second opinion from another member.
label
Sep 27, 2019
MartinHjelmare
removed
the
second-opinion-wanted
Add this label when a reviewer needs a second opinion from another member.
label
Oct 1, 2019
MartinHjelmare
approved these changes
Oct 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Instead of prompting a user to provide an existing token, will redirect them to the plex.tv website to complete authentication and will obtain a token on their behalf with an OAuth-like process. Relies on new library plexauth.
This new auth method has the added benefit of showing a separate "Home Assistant" authorized device on the Plex account, instead of the legacy method of hijacking an existing authenticated device's token.
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10462
Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
.If the code does not interact with devices: