Disable flaky/slow ecobee test #27125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -116,6 +117,7 @@ | |||
| assert result["description_placeholders"] == {"pin": "test-pin"} | |||
|
|
|||
|
|
|||
| @pytest.mark.skip(reason="Flaky/slow") | |||
| async def test_import_flow_triggered_but_no_ecobee_conf(hass): | |||
There was a problem hiding this comment.
We're missing patching in this test. We should patch the load json util.
Seems more setup is needed to complete this test too, eg populate hass.data.
MartinHjelmare
approved these changes
Oct 2, 2019
|
I’m planning to take a look at the whole ecobee test suite soon so I’ll make sure to address this then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test
test_import_flow_triggered_but_no_ecobee_confis slow and flaky:https://dev.azure.com/home-assistant/Home%20Assistant/_build/results?buildId=10880&view=logs&j=641e29f4-92ec-5dde-69c3-b45a7bd26967&t=a889306f-ddd6-5fc9-6488-5f3f5770f1cb&l=273
https://dev.azure.com/home-assistant/Home%20Assistant/_build/results?buildId=10867&view=logs&j=641e29f4-92ec-5dde-69c3-b45a7bd26967&t=a889306f-ddd6-5fc9-6488-5f3f5770f1cb&l=273
Disable the test for now, ping @marthoc