Media player send key service

[tulindo]

Breaking Change:

None

Description:

Creation of the new media_send_key service. This will allow to send to the media player a control key (just like an IR remote control).
This can be useful to implement at frontend level a generic remote control to deal with television.

The service is also been implemented for samsungtv component.

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the [development checklist][dev-checklist]

[tulindo]

Can someone tell me what is the error behind the codecov/patch test. How can I address it?
Thanks
Paolo

[frenck]

Hi there, @tulindo!

That is because you've adjusted on of our internal/core components: media_player. Those are equipped with unit tests. Since you've added new features to it, it will need to be unit-tested. So please add those.

Besides all that, it might need to be discussed in our architectural repository first: https://github.com/home-assistant/architecture

[tulindo]

Thanks @frenck you've been very clear.
I'm going to add that.
I'm only surprised that the codecov complains about the samungtv component and not the core media player. @MartinHjelmare what do you think?

It sounds logical that being media player a core component it has to be discussed somewhere... But I didn't know how to start a discussion.
Now I know! Thanks again

[dgomes]

This will need to be first reviewed in home-assistant/architecture#299

[dgomes]

these must be reduced to the common denominator (probably numbers + prog + volume + power)

[MartinHjelmare]

The samsungtv integration has tests. They need to be extended when new code is added to keep coverage in line.

https://github.com/home-assistant/home-assistant/blob/da29c1125fac4fd9059ffec82899d65e751ef6be/tests/components/samsungtv/test_media_player.py#L1

[MartinHjelmare]

Let's close this since the architecture issue discussion points in another direction.