Add observed entities to bayesian sensor

[paolog89]

Description:

The Bayesian binary sensor currently shows only a list of [object Object] under the field observations:

This change will include the list of entities that have been observed:

Related issue (if applicable): N/A

Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable): N/A

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

If the code does not interact with devices:

• Tests have been added to verify that the new code works.

[homeassistant]

Hi @paolog89,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[sophof]

@paolog89 This change would be really useful to me, thanks! Checking your code though I think it will duplicate entity ids that are relevant for multiple observations. You might want to create a unique set.

[paolog89]

@paolog89 This change would be really useful to me, thanks! Checking your code though I think it will duplicate entity ids that are relevant for multiple observations. You might want to create a unique set.

@sophof Thanks for your feedback. Isn't that also a feature? This way you can see if you have multiple observations.

[sophof]

@paolog89 This change would be really useful to me, thanks! Checking your code though I think it will duplicate entity ids that are relevant for multiple observations. You might want to create a unique set.

@sophof Thanks for your feedback. Isn't that also a feature? This way you can see if you have multiple observations.

I guess so, but won't it be impossible to differentiate them anyway if an entity trigger multiple observations? I worry that especially with libera l use of templates (I'm working on an update that enhances templates) it'll get very spammy...

[dgomes]

Tests need to pass but looks good

[paolog89]

Tests need to pass but looks good

Thanks! Do I need to do something?

[springstan]

@paolog89 you will need to format your code with black :)

[balloob]

We don't make changes to the backend based on a display issue in the frontend.

You're also removing an existing attribute and replace the content with something else, that does not match the name.

[paolog89]

We don't make changes to the backend based on a display issue in the frontend.

You're also removing an existing attribute and replace the content with something else, that does not match the name.

Hello Paulus, would it be ok to add an attribute with the observed entities? how would you solve the fronted issue?

[balloob]

Yes a new attribute is fine.

Open an issue on the frontend repo

[paolog89]

There is an issue on the frontend repo [#3689](https://github.com/home-assistant/home-assistant-polymer/issues/3689). Can you re-open it or should I open a new one?

Can you re-open this pull request or should I open a new one?

[balloob]

Done and done.

[codecov]

Codecov Report

Merging #27721 into dev will increase coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev   #27721      +/-   ##
==========================================
+ Coverage   94.41%   94.64%   +0.22%     
==========================================
  Files         626      756     +130     
  Lines       47140    54840    +7700     
==========================================
+ Hits        44506    51901    +7395     
- Misses       2634     2939     +305     

Impacted Files	Coverage Δ
homeassistant/components/recorder/migration.py	62.40% <0.00%> (-30.73%)	⬇️
homeassistant/components/google_assistant/http.py	79.16% <0.00%> (-9.97%)	⬇️
homeassistant/bootstrap.py	72.61% <0.00%> (-7.51%)	⬇️
homeassistant/components/ring/sensor.py	86.86% <0.00%> (-8.84%)	⬇️
homeassistant/components/ring/light.py	89.79% <0.00%> (-8.25%)	⬇️
homeassistant/components/updater/binary_sensor.py	92.10% <0.00%> (-7.90%)	⬇️
...istant/components/google_assistant/report_state.py	85.00% <0.00%> (-4.19%)	⬇️
homeassistant/__init__.py	88.46% <0.00%> (-7.43%)	⬇️
homeassistant/components/light/device_action.py	93.93% <0.00%> (-6.07%)	⬇️
homeassistant/components/mfi/switch.py	89.28% <0.00%> (-5.36%)	⬇️
... and 558 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c700085...7447797. Read the comment docs.

[balloob]

You need to sort the output in your tests. Sets are not sorted.