Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ATEN PE component for ATEN eco PDUs #27960

Merged
merged 10 commits into from Dec 1, 2019
Merged

Add ATEN PE component for ATEN eco PDUs #27960

merged 10 commits into from Dec 1, 2019

Conversation

mtdcr
Copy link
Contributor

@mtdcr mtdcr commented Oct 20, 2019

Description:

This component integrates ATEN power distribution units. A PE8324 was used for development. It fetches configured names from the PDU and creates a switch for each outlet. Communication is done via SNMP.

Pull request with documentation for home-assistant.io: home-assistant/home-assistant.io#11301

Example entry for configuration.yaml, using SNMPv3:

switch:
  - platform: aten_pe
    host: mypdu.lan.
    auth_key: !secret mypdu_authkey
    priv_key: !secret mypdu_privkey

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@springstan
Copy link
Member

@mtdcr please open a PR to update the documentation accordingly :)

@mtdcr
Copy link
Contributor Author

mtdcr commented Nov 26, 2019

@mtdcr please open a PR to update the documentation accordingly :)

Done.

@frenck frenck removed the cla-signed label Nov 26, 2019
frenck
frenck previously requested changes Nov 26, 2019
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, @mtdcr!

I've done an initial review of your PR and left some comments.
Could you please take a look? Thanks! 👍

homeassistant/components/aten_pe/switch.py Outdated Show resolved Hide resolved
homeassistant/components/aten_pe/switch.py Outdated Show resolved Hide resolved
homeassistant/components/aten_pe/switch.py Outdated Show resolved Hide resolved
homeassistant/components/aten_pe/switch.py Outdated Show resolved Hide resolved
homeassistant/components/aten_pe/switch.py Outdated Show resolved Hide resolved
homeassistant/components/aten_pe/switch.py Show resolved Hide resolved
homeassistant/components/aten_pe/manifest.json Outdated Show resolved Hide resolved
Dev automation moved this from Needs review to Review in progress Nov 26, 2019
@project-bot project-bot bot moved this from Review in progress to Needs review in Dev Nov 27, 2019
@mtdcr
Copy link
Contributor Author

mtdcr commented Nov 27, 2019

Thanks for your review, @frenck. Please have a look at my comments.

@mtdcr
Copy link
Contributor Author

mtdcr commented Nov 27, 2019

The label "docs-missing" can be removed now.

@frenck frenck dismissed their stale review November 28, 2019 10:44

I approve, however, I want to have a more experienced reviewer to have a final call.

Dev automation moved this from Needs review to Review in progress Nov 28, 2019
@frenck frenck moved this from Review in progress to Second opinion wanted in Dev Nov 28, 2019
@frenck frenck added the second-opinion-wanted Add this label when a reviewer needs a second opinion from another member. label Nov 28, 2019
Dev automation moved this from Second opinion wanted to Review in progress Nov 29, 2019
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some comments.

homeassistant/components/aten_pe/manifest.json Outdated Show resolved Hide resolved
homeassistant/components/aten_pe/switch.py Outdated Show resolved Hide resolved
homeassistant/components/aten_pe/switch.py Show resolved Hide resolved
@MartinHjelmare MartinHjelmare removed the second-opinion-wanted Add this label when a reviewer needs a second opinion from another member. label Nov 29, 2019
@springstan
Copy link
Member

Update your dependencies by running python3 -m script.gen_requirements_all to fix the Overview Validate issue.

@mtdcr
Copy link
Contributor Author

mtdcr commented Nov 30, 2019

Update your dependencies by running python3 -m script.gen_requirements_all to fix the Overview Validate issue.

Done, thank you!

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Dev automation moved this from Review in progress to Reviewer approved Dec 1, 2019
@MartinHjelmare MartinHjelmare merged commit 64628c1 into home-assistant:dev Dec 1, 2019
Dev automation moved this from Reviewer approved to Done Dec 1, 2019
@mtdcr
Copy link
Contributor Author

mtdcr commented Dec 1, 2019

Thank you, Martin!

@mtdcr mtdcr deleted the aten_pe branch December 1, 2019 21:28
@lock lock bot locked and limited conversation to collaborators Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants