Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stop feature to tradfri covers #28180

Merged
merged 5 commits into from Oct 24, 2019
Merged

Add stop feature to tradfri covers #28180

merged 5 commits into from Oct 24, 2019

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Oct 24, 2019 •
edited

Description:

  • Adds stop capability to the cover.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.

@project-bot project-bot bot added this to Needs review in Dev Oct 24, 2019
@probot-home-assistant
Copy link

Hey there @ggravlingen, mind taking a look at this pull request as its been labeled with a integration (tradfri) you are listed as a codeowner for? Thanks!

@ludeeus ludeeus mentioned this pull request Oct 24, 2019
Merged
4 tasks
@ludeeus ludeeus marked this pull request as ready for review October 24, 2019 19:07
Dev automation moved this from Needs review to Review in progress Oct 24, 2019
@ludeeus ludeeus changed the title Tradfri cover enhancements Adds stop feature to tradfri covers Oct 24, 2019
@ludeeus
Copy link
Member Author

ludeeus commented Oct 24, 2019

Added requested changes, updated the title and the description.

Dev automation moved this from Review in progress to Reviewer approved Oct 24, 2019
MartinHjelmare
MartinHjelmare approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare changed the title Adds stop feature to tradfri covers Add stop feature to tradfri covers Oct 24, 2019
@balloob balloob merged commit ec478ab into home-assistant:dev Oct 24, 2019
Dev automation moved this from Reviewer approved to Done Oct 24, 2019
@ludeeus ludeeus deleted the tradfri2 branch October 24, 2019 20:40
@lock lock bot locked and limited conversation to collaborators Oct 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggravlingen ggravlingen ggravlingen requested changes

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cla-signed Hacktoberfest integration: tradfri small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ludeeus @MartinHjelmare @ggravlingen @balloob @homeassistant