Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match ALARM in NUT UPS status message #28591

Merged
merged 1 commit into from Nov 7, 2019

Conversation

bwarden
Copy link
Contributor

@bwarden bwarden commented Nov 6, 2019

Description:

If ups.status contains "ALARM", add "Alarm" to virtual sensor ups.status.display.

Related issue (if applicable): fixes #28580

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

If ups.status contains "ALARM", add "Alarm" to virtual sensor ups.status.display.

Fixes home-assistant#28580
@probot-home-assistant probot-home-assistant bot added integration: nut small-pr PRs with less than 30 lines. labels Nov 6, 2019
@project-bot project-bot bot added this to Needs review in Dev Nov 6, 2019
Copy link
Contributor

@cgtobi cgtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Dev automation moved this from Needs review to Reviewer approved Nov 7, 2019
@bachya bachya merged commit 1012215 into home-assistant:dev Nov 7, 2019
Dev automation moved this from Reviewer approved to Done Nov 7, 2019
@bwarden bwarden deleted the add-alarm-to-nut-ups-status branch November 8, 2019 00:10
@lock lock bot locked and limited conversation to collaborators Nov 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed integration: nut small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Add ALARM to recognized NUT UPS status STATE_TYPES
4 participants