Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GIOS integration #28719
Add GIOS integration #28719
Changes from 11 commits
1ab5e62
402f98e
3ddb7a1
a967894
9095528
7ae4816
cc4b9d2
1ac766b
42e6426
25f1758
0cc6e0c
01fe7c9
308ff56
e8830e8
5ea508f
409e0ef
f254d4c
429c3ed
96928c7
7ddd484
ac10b5a
333cbe6
ae15c32
8cd6d8f
0d3be85
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be defined as constants (better even if defined in the backend library) in english.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GIOS server sends AQI states in Polish. Do you think I need to translate those to English in backend library?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no other identifier besides the (translated) string? Imo it would make sense to have those as constants as it is just cleaner that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AQI state strings from server are only in Polish. I added consts with English names for that states. I think that it's now understandable for non-Polish people.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should rounding be left to the consumers of the data? I don't personally mind, but I think someone might :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rytilahti In Poland, most air quality services on the Internet rounding off values. I think this is a good approach.