Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark entity abc #28869

Merged
merged 3 commits into from
Nov 19, 2019
Merged

Mark entity abc #28869

merged 3 commits into from
Nov 19, 2019

Conversation

balloob
Copy link
Member

@balloob balloob commented Nov 18, 2019

Description:

Mark Entity class an ABC so we can add abstract methods.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from a team as a code owner November 18, 2019 23:20
@balloob
Copy link
Member Author

balloob commented Nov 19, 2019

By adding this to more integrations, we'll be able to find integrations that are not implementing the right methods.

@balloob balloob merged commit 94675ca into dev Nov 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the mark-entity-abc branch November 19, 2019 19:42
@lock lock bot locked and limited conversation to collaborators Nov 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pvizeli pvizeli pvizeli approved these changes

Assignees
No one assigned
Labels
cla-signed core has-tests integration: climate small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@balloob @pvizeli @homeassistant